Hello all.

TLDR;
- Should I rewrite the UtilCache tests ?
- If so, is groovy acceptable for cache tests ?

During the upgrade of Java version [1], I had to read and understand the JavaUtilCacheTest.java class. These tests were written in 2010 and barely updated since (functionnaly at least),
and relied on Hamcrest library.
I removed the hamcrest dependency for these tests and replaced it by native Junit, and renames some of the variables to explicit their usage. I would like to offer to completely rewrite this test class, but i don't kow if that is the right course of action, or even acceptable. If so, considering that these tests are quite low level, would it be acceptable if they were written in groovy ?

Thanks and regards,
Gaƫtan

[1] https://issues.apache.org/jira/browse/OFBIZ-13306

Reply via email to