[
https://issues.apache.org/jira/browse/OFBIZ-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552385
]
Bilgin Ibryam commented on OFBIZ-1499:
--------------------------------------
Hi Sumit,
I like your idea to pass surveyResponseId to calculateProductPrice and then to
the customMethod
I got a question about these lines:
+ if (UtilValidate.isEmpty(surveyResponseId) &&
paramMap.containsKey("surveyResponseId")) {
+ surveyResponseId = (String)
paramMap.get("surveyResponseId"); // if SurveyResponceId is not getting from
attribute then we can try to access it from paramMap.
+ }
Are there situations where surveyResponseId is not presented in
requestAttributes, but exist in requestParameters?
One more thing: It is very important to document your code, but also i would
recommend you to keep in mind this: *Document why something is being done, not
just what.*
Thank you for your work.
Bilgin
> When survey products are added to the cart then displaying survey price in
> the cart and adding it to the cart total.
> --------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1499
> URL: https://issues.apache.org/jira/browse/OFBIZ-1499
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Sumit Pandit
> Assignee: Bilgin Ibryam
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: surveyProduct.patch, surveyProduct.patch
>
>
> 1) Set surveyResponseId in service :-
> calculateProductPrice(services_pricepromo.xml)
> 2) Pass surveyResponseId with inMap in calculateProductPrice method
> (PriceServices.java)
> Thanks to Anil Patel & Sumit Porwal for helping me in implementing this
> changes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
