Hello,

All the checks ran successfully here:
https://github.com/apache/ofbiz-framework/pull/1516

I am looking into it and will provide the fix of this failure soon.

Thanks,
Ashish Vijaywargiya


On Thu, 30 Jul 2026 at 11:17, GitBox <[email protected]> wrote:

>
> The GitHub Actions job "CodeQL" on ofbiz-framework.git/trunk has failed.
> Run started by GitHub user ashishvijaywargiya (triggered by
> ashishvijaywargiya).
>
> Head commit for run:
> dc80d7f434a3b985cb5a0a1becc975d9c65e44eb / Ashish Vijaywargiya <
> [email protected]>
> Migrate UEL unit tests (Date/Math/String/Misc) from JUnit3 testdef to
> Jupiter(JUnit5) (#1516)
>
> UEL Unit Test Migration
>
> 1) I migrated the four UEL unit tests (Date, Math, String, Misc) from
> the old JUnit3 testdef XML format to plain JUnit5/Jupiter tests so they
> run through a fast gradlew test instead of the full OFBiz test
> container.
>
> 2) UelFunctions.FUNCTION_MAPPER is built once per JVM by scanning
> ComponentConfig, and ComponentConfig is normally only populated by
> ComponentContainer during a real OFBiz boot, so these lightweight
> Jupiter tests needed their own way to trigger just that piece.
>
> 3) Added ComponentContainerTestSupport.java as a test-only bridge class
> living in the same package as ComponentContainer, so it can call its
> package-private init(String, Path) method without widening that method's
> visibility in production code.
>
> 4) Added UelTestSupport.groovy as the idempotent helper that checks
> whether components are already loaded and triggers the bootstrap through
> ComponentContainerTestSupport exactly once per JVM.
>
> 5) Added UelFunctionsBootstrapListener.groovy, registered via
> META-INF/services as a JUnit Platform LauncherSessionListener, so the
> bootstrap runs once before any test in the JVM is discovered, regardless
> of which test class Gradle happens to run first.
>
> 6) That listener now loads the real, full component tree into the
> JVM-wide ComponentConfig cache for every test run, so we renamed the
> ComponentContainerTest fixture components from order/accounting to
> test-order/test-accounting to avoid name collisions with the real
> components.
>
> 7) Updated ComponentContainerTest.java to filter its assertions down to
> just its own fixture names so the test stays a genuine check of
> dependency sorting regardless of what else is loaded into the shared
> cache.
>
> 8) Removed the four uel-*-tests test-cases from
> framework/base/testdef/basetests.xml since they no longer run through
> the old JUnit3 testtools container.
>
> 9) Added the junit-platform-launcher dependency to dependencies.gradle
> since that library is what actually discovers and invokes the new
> LauncherSessionListener.
>
> 10) I also verified the branch with gradlew test for the UEL and base
> packages, checkstyleTest and codenarcTest, and both a scoped and a full
> testIntegration run, with all suites passing.
>
> Report URL:
> https://github.com/apache/ofbiz-framework/actions/runs/30517486832
>
> With regards,
> GitHub Actions via GitBox
>
>

Reply via email to