Hello Mridul, I set-up ofbiz trunk on the latest code base. I missed sharing this info in my previous email so sharing it here for reference purposes.
ashish@Ashish-Vijaywargiya ofbiz-trunk % git branch * trunk ashish@Ashish-Vijaywargiya ofbiz-trunk % git rev-parse --short HEAD e103805ef7 ashish@Ashish-Vijaywargiya ofbiz-trunk % git log commit e103805ef7f15e9f3802e97b0a5c8a6cb47032b2 (HEAD -> trunk, origin/trunk, fork/trunk, fork/HEAD) Author: Mridul Pathak <[email protected]> Date: Sun Nov 8 00:02:18 2026 +0530 Reject a malformed CSV file instead of throwing in SecuredUpload When commons-csv cannot parse an uploaded file, for instance because of an unterminated quote, CSVParser.getRecords() throws an UncheckedIOException that isValidCsvFile did not catch, so isValidFile threw instead of returning false, both for the CSV type and for the All type when a file failing the other checks contained a stray quote. The upload then ended with an unexpected error instead of the supported-formats message, and the rejected file was not deleted. isValidCsvFile now catches the parsing exception, logs it and returns false. Thanks, Ashish Vijaywargiya On Tue, 10 Nov 2026 at 12:31, Ashish Vijaywargiya <[email protected]> wrote: > Hello Mridul, > > Thank you for taking care of this upgrade. It's very helpful for the > Apache OFBiz project. > > I just setup ofbiz trunk on my laptop and will say "All is Well" from the > setup point of view on Java25. 👏👍🙏 > > 2026-11-10 12:21:48,706 |main |EntityDataLoadContainer > :587|I| 00003 of 15712 from > file:/Users/ashish/ofbiz-dev/ofbiz-trunk/plugins/passport/data/OAuth2GitHubSeedData.xml > 2026-11-10 12:21:48,706 |main |EntityDataLoadContainer > :587|I| 00014 of 15726 from > file:/Users/ashish/ofbiz-dev/ofbiz-trunk/plugins/projectmgr/data/ProjectMgrSecurityGroupDemoData.xml > 2026-11-10 12:21:48,706 |main |EntityDataLoadContainer > :587|I| 00135 of 15861 from > file:/Users/ashish/ofbiz-dev/ofbiz-trunk/plugins/projectmgr/data/ProjectMgrDemoData.xml > 2026-11-10 12:21:48,706 |main |EntityDataLoadContainer > :587|I| 00006 of 15867 from > file:/Users/ashish/ofbiz-dev/ofbiz-trunk/plugins/projectmgr/data/ProjectMgrDemoPasswordData.xml > 2026-11-10 12:21:48,706 |main |EntityDataLoadContainer > :587|I| 00133 of 16000 from > file:/Users/ashish/ofbiz-dev/ofbiz-trunk/plugins/scrum/data/scrumSecurityGroupDemoData.xml > 2026-11-10 12:21:48,706 |main |EntityDataLoadContainer > :587|I| 00215 of 16215 from > file:/Users/ashish/ofbiz-dev/ofbiz-trunk/plugins/scrum/data/scrumDemoData.xml > 2026-11-10 12:21:48,707 |main |EntityDataLoadContainer > :593|I| =-=-=-=-=-=-= Finished the data load with 16215 rows changed. > 2026-11-10 12:21:48,707 |main |ContainerLoader > :105|I| Loaded container: dataload-container > 2026-11-10 12:21:48,707 |main |ContainerLoader > :102|I| Loading container: lucene-container > 2026-11-10 12:21:48,707 |main |ContainerLoader > :105|I| Loaded container: lucene-container > 2026-11-10 12:21:48,707 |main |ContainerLoader > :147|I| [Startup] Starting containers... > 2026-11-10 12:21:48,707 |main |ContainerLoader > :149|I| Starting container component-container > 2026-11-10 12:21:48,707 |main |ContainerLoader > :155|I| Started container component-container > 2026-11-10 12:21:48,707 |main |ContainerLoader > :149|I| Starting container datasource-container > 2026-11-10 12:21:48,707 |main |ContainerLoader > :155|I| Started container datasource-container > 2026-11-10 12:21:48,707 |main |ContainerLoader > :149|I| Starting container service-container > 2026-11-10 12:21:48,707 |main |ContainerLoader > :155|I| Started container service-container > 2026-11-10 12:21:48,707 |main |ContainerLoader > :149|I| Starting container dataload-container > 2026-11-10 12:21:48,707 |main |ContainerLoader > :155|I| Started container dataload-container > 2026-11-10 12:21:48,707 |main |ContainerLoader > :149|I| Starting container lucene-container > 2026-11-10 12:21:48,707 |main |ContainerLoader > :155|I| Started container lucene-container > 2026-11-10 12:21:48,707 |main |ContainerLoader > :163|I| Shutting down containers > 2026-11-10 12:21:48,707 |main |ContainerLoader > :165|I| Stopping container lucene-container > 2026-11-10 12:21:48,796 |main |ContainerLoader > :172|I| Stopped container lucene-container > 2026-11-10 12:21:48,796 |main |ContainerLoader > :165|I| Stopping container dataload-container > 2026-11-10 12:21:48,796 |main |ContainerLoader > :172|I| Stopped container dataload-container > 2026-11-10 12:21:48,796 |main |ContainerLoader > :165|I| Stopping container service-container > 2026-11-10 12:21:48,798 |main |JobPoller > :243|I| Shutting down JobPoller. > 2026-11-10 12:21:48,798 |OFBiz-JobPoller |JobPoller > :283|I| JobPoller thread started. > 2026-11-10 12:21:48,798 |main |JobPoller > :265|I| JobPoller shutdown completed. > 2026-11-10 12:21:48,798 |OFBiz-JobPoller |JobPoller > :349|I| JobPoller thread stopped. > 2026-11-10 12:21:48,798 |main |ServiceContainer > :109|I| Removing from cache dispatcher: entity-default > 2026-11-10 12:21:48,798 |main |ServiceDispatcher > :203|I| De-Registering dispatcher: entity-default > 2026-11-10 12:21:48,798 |main |ServiceDispatcher > :915|I| Shutting down the service engine... > 2026-11-10 12:21:48,798 |main |ContainerLoader > :172|I| Stopped container service-container > 2026-11-10 12:21:48,798 |main |ContainerLoader > :165|I| Stopping container datasource-container > 2026-11-10 12:21:48,798 |main |DataSourceContainer > :53|I| Closing the datasources > 2026-11-10 12:21:49,018 |main |ContainerLoader > :172|I| Stopped container datasource-container > 2026-11-10 12:21:49,018 |main |ContainerLoader > :165|I| Stopping container component-container > 2026-11-10 12:21:49,018 |main |ContainerLoader > :172|I| Stopped container component-container > 2026-11-10 12:21:49,018 |retProvider-Shutdown |SecretProviderFactory > :71|I| SecretProvider: provider closed on shutdown > > > Task :loadAll > > [Incubating] Problems report is available at: > file:///Users/ashish/ofbiz-dev/ofbiz-trunk/build/reports/problems/problems-report.html > > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 10. > > You can use '--warning-mode all' to show the individual deprecation > warnings and determine if they come from your own scripts or plugins. > > For more on this, please refer to > https://docs.gradle.org/9.8.2/userguide/command_line_interface.html#sec:command_line_warnings > in the Gradle documentation. > > BUILD SUCCESSFUL in 51s > 47 actionable tasks: 32 executed, 15 up-to-date > ashish@Ashish-Vijaywargiya ofbiz-trunk % java -version > openjdk version "25.0.5" 2026-10-20 LTS > OpenJDK Runtime Environment Temurin-25.0.5+8 (build 25.0.5+8-LTS) > OpenJDK 64-Bit Server VM Temurin-25.0.5+8 (build 25.0.5+8-LTS, mixed mode, > sharing) > ashish@Ashish-Vijaywargiya ofbiz-trunk % javac -version > javac 25.0.5 > > Thanks, > Ashish Vijaywargiya > > On Thu, 5 Nov 2026 at 20:02, Mridul Pathak via dev <[email protected]> > wrote: > >> Hi all, >> >> Following the proposal on dev@, OFBiz trunk now builds and runs on >> Java 25 (OFBIZ-13790). The source and target level, the GitHub CI, >> CodeQL, BuildBot, the Docker images and the devcontainer have all >> moved to JDK 25. The release24.09 branch stays on Java 17, so nothing >> changes if you work on 24.09. >> >> If you build trunk, install a JDK 25 and point JAVA_HOME at it before >> you pull, otherwise the build fails with "invalid source release: 25". >> Any Temurin or other OpenJDK 25 build works. Java compiler warnings >> now also fail the build, and this includes the Java code of your own >> plugins and components: fix the warnings, or build with "./gradlew >> -PXlint:none" to turn the lint and the failure off. >> >> These changes, and everything else that changed on trunk since 24.09, >> are described in the upgrade notes, which also cover the Gradle 9, >> Tomcat 11 (Jakarta EE), Groovy 6 and H2 moves: >> https://github.com/apache/ofbiz-framework/blob/trunk/UPGRADING.md >> >> Moving off Java 17 also lets us take the dependency upgrades we have >> been holding back, such as Lucene 10, which I will look at next. >> >> Thanks to everyone who reviewed the proposal and the pull requests. If >> you run into a problem building or running trunk on Java 25, please >> reply here or open a Jira issue. >> >> Best Regards >> Mridul Pathak >> https://www.linkedin.com/in/mridulpathak/ >> >
