[ 
https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552526
 ] 

Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------

Thanks Chris,

Your patch is in trunk revision: 604993. Some advices, questions and remarks :

Please don't add xpos.properties in your patches. As you may know this file is 
dynamically modified by the system to allow XUI localisation. About this 
subject I have added the following lines
    ### This file contains labels directly translated by XUI framework
    ### This file contains labels translated by the POS component (ie not by 
XUI framework)
in respectively XuiUilabels*.properties files and pos*.properties file to make 
things more obvious.

Should we keep PosTransaction.configureItem commented ?

Please update or remove code comments, for instance the one I already noticed 
in a comment above

I commented some remaining Debug.logInfo in ConfigureItem feel free to 
uncomment if you feel they are needed.

Thanks for your great work, I love the color !






> Ability to add items with modifiers
> -----------------------------------
>
>                 Key: OFBIZ-1109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1109
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: 16Dec2007.patch, 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via 
> the POS system.  
> A few scenarios should be supported.
> 1.  The item has a default configuration and can be added without 
> configuration.
> 2.  The item requires configuration and a screen to configure the item should 
> present upon adding the item.
> 3.  A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1.  Is anyone else interested in this functionality?
> 2.  What does everyone think is the best way to accomplish this?
> Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to