[ 
https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557973#action_12557973
 ] 

Bilgin Ibryam commented on OFBIZ-1453:
--------------------------------------

The first rule from General Responsibilities of Committers says "first do no 
harm".
That's why I think there is one more thing to add to this patch before 
committing it.

Currently, createProductionRunFromConfiguration service creates a production 
run for every ordered AGGREGATED product and after completing the production 
run the AGGREGATED product is added to inventory. 

But after applying this patch, the AGGREGATED products will be replaced by a 
new AGGREGATED_CONF type products, and the order is created for these new 
products.

So i think to do the following:
1. while creating and associating the new AGGREGATED_CONF, also copy the 
ROU_PROD_TEMPLATE from AGGREGATED product:

Example: while ordering PC001, create new product, associate it the PC001, and 
create a new WorkEffortGoodStandard for the new product, by copying it from 
PC001
    <WorkEffortGoodStandard workEffortId="ROUT01" productId="PC001" 
workEffortGoodStdTypeId="ROU_PROD_TEMPLATE" statusId="WEGS_CREATED" 
fromDate="2004-09-24 15:10:14.227"/>

    <WorkEffortGoodStandard workEffortId="ROUT01" productId="newProductId" 
workEffortGoodStdTypeId="ROU_PROD_TEMPLATE" statusId="WEGS_CREATED" 
fromDate="2004-09-24 15:10:14.227"/>

2. Do a small change in createProductionRunFromConfiguration service for 
calling createProductionRun service with the new AGGREGATED_CONF productId.

What do you think ? 
I'd love to know also Jacopo's opinion on this.

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, 
> aggregated_full_for_review.patch, aggregated_full_for_review.patch, 
> aggregated_full_for_review.patch, aggregated_full_for_review.patch, 
> aggregated_full_for_review.patch, aggregated_full_for_review.patch, 
> aggregated_full_for_review.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to