[
https://issues.apache.org/jira/browse/OFBIZ-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558768#action_12558768
]
Jacques Le Roux commented on OFBIZ-1569:
----------------------------------------
Abhijit,
I think you asked for comments, here they are :
You should not have put this lines in the patch :
+ <service name="checkFacilityRelatedPermission" engine="simple"
+ location="org/ofbiz/product/inventory/InventoryServices.xml"
invoke="checkFacilityRelatedPermission">
+ <description>Facility Permission Checking Logic</description>
+ <implements service="permissionInterface"/>
+ </service>
When Jacopo created this simple-method (checkFacilityRelatedPermission,
r547934) he put this comment
<!-- a method to centralize facility security code, meant to be called
in-line with
call-simple-method, and the checkAction and callingMethodName
attributes should be in the method context -->
Hence you should not have called it but in-line, facilityGenericPermission
should have been called in place.
In revision 611917 I definitevely supressed checkFacilityRelatedPermission as a
service. It never should have been one.
Thanks for your work.
> Re-Factor Facility permissions of Product component to follow new patterns.
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1569
> URL: https://issues.apache.org/jira/browse/OFBIZ-1569
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Reporter: Abhijit Meshram
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: facility_security.patch, facility_security.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
