[
https://issues.apache.org/jira/browse/OFBIZ-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562219#action_12562219
]
Jacques Le Roux commented on OFBIZ-1580:
----------------------------------------
Chris,
Some points to note, after a cursory review :
. I will use (commit later) XuiCoreSwing-v3.2rc2b.jar and
XuiOptional-v3.2rc2b.jar. Some time ago, we decided to put revision number in
filename, to facilitate migrations.
. I saw that you replaced the var name session by xuisession. It seems good to
me but please in such prefer to use something like xuiSession (and if you have
a doubt please (re?)-read
http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions ;o)
. We should remove the comment + //causes infinite loop
. We have to clear // XUI upgraded to 3.2 from 2.0.6 - still ignore?
. Please only add relevants lines in xpos.properties. For this you have to
revert the file before. Don't worry it is dynamically modified by OFBiz..
Notably take care with the UseWindow option : please keep its comment and its
state. So in this case you have only to add the 2 lines
StartClass=specialpurpose/pos/screens/default/pospanel
StyleFile=specialpurpose/pos/styles/posstyles.xml
. I have commented the line //Debug.logInfo(getModelText(jmodel), module); in
Journal.java:158
. Some time ago I changed the way the journal was showing, and allowed to
scroll horizontally. Please see why on the POS XUI 3.2rc2b.PNG file attached :
the grand total might be trunked.
At this stage I can only say 2 other words : great work !
I will continue to review tomorrow...
PS : I attach the updated patch. I keep the same name intentionally, I think
you will figure out why instantly. In this patch the points below remain
. We have to clear // XUI upgraded to 3.2 from 2.0.6 - still ignore?
. Some time ago I changed the way the journal was showing and allowed to scroll
horizontally. Please see why on the POS XUI 3.2rc2b.PNG file attached : the
grand total might be trunked.
> XUI update to x3.1
> ------------------
>
> Key: OFBIZ-1580
> URL: https://issues.apache.org/jira/browse/OFBIZ-1580
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: ofbiz-1580-6.patch, POS XUI 3.2rc2b.PNG
>
>
> I have been having problems with the limitations of the current version of
> XUI. Specifically, the limitations of not being able to remove event
> handlers and the forced caching of XPage objects.
> It compiles, but it throws an exception at runtime.
> I think it is a configuration issue, I haven't tracked it down yet, but I
> thought I'd put it out here in case anyone wants to take a look.
> Run the patch, then delete the following files:
> rm specialpurpose/pos/src/org/ofbiz/pos/screen/ConfigureItem.java
> rm specialpurpose/pos/src/org/ofbiz/pos/screen/LoadSale.java
> rm specialpurpose/pos/src/org/ofbiz/pos/screen/PaidInOut.java
> rm specialpurpose/pos/src/org/ofbiz/pos/screen/SaveSale.java
> rm specialpurpose/pos/src/org/ofbiz/pos/screen/SelectProduct.java
> I updated Journal.java, but I want to see it work before I update the other
> files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
