[ 
https://issues.apache.org/jira/browse/OFBIZ-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569394#action_12569394
 ] 

Valentina Sirkova commented on OFBIZ-1590:
------------------------------------------

Here is my second comment.
Hans and community,

I would say the current implementation of OFBiz has the following cons:
 1. Duplication of data:(Workeffort and TechDataCal entities)
 2. Room types are presented as fixedAssets which is not the right way.They are 
classes!
 3. Numbering problem (room numbers, seat numbers)
 4. We don`t distinguish the people. We don`t have children and adults but just 
people.
 5. Check availability method works only for dayly reservations.  But we need 
hourly reservations as well.

The entities that I proposed and described in the wiki are not intended to be 
realted to Workeffort. If you look at the data model you will see that they are 
related to Reservation and ReservationItem. Personally I find their logical 
place in our system in the OrderHeader and OrderItem entities, but correct me 
if I am wrong.

If Hans chooses to extend Workeffort anyway then this won`t solve many of the 
cons mentioned above, but even add more as  the logical distinction of 
WorkEffort and Reservations will be totally lost.

If we extend OrderHeader and OrderItem and commit the entities that i proposed 
we will get rid of all of the cons 1,2,3,5 and create a base for taking care of 
4.

Personally I would be very happy to work with Hans and the community as I 
myself am involved in a hotel project and more specifically in building its 
reservation system. I would be happy to provide you with patches in the near 
future (as near as possible)resoloving all of the cons mentioned above. But I 
do need your feedback on my ideas as I might be wrong and need advice.....

Thanks for your time :)


> Introduction of new reservation entities
> ----------------------------------------
>
>                 Key: OFBIZ-1590
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1590
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Valentina Sirkova
>         Attachments: accomEntity.patch, accomProgram.patch, 
> spot_class_map_entities.patch, spot_class_map_entities.patch
>
>
> I propose the introduction of the following entities: AccommodationClass, 
> AccommodationSpot,AccommodationMap. Their design is based on the book "The 
> data model resource book". 
>  -  AccommodationClass could define classes for hotels, cars, planes etc. I 
> have added one more field here parentAccClass, as I thought it could be 
> valuable for building more complicated hierarchies.
>  -  AccommodationMap is used to say how many spaces a class has. I have 
> extended it further with a field overbooked, which could store the 
> overbooking data for each class. E.g if we have that field we might know how 
> many rooms of class "deluxe" could be overbooked. The primary key of 
> AccommodationMap in the book includes the "NrOfSpaces" field but I did not 
> add it in the patch as I am not sure of its exact purpose.
>  - AccommodationSpot defines the specific seat,room etc of a given class. It 
> is very powerful entity as it let us define the seat as a spot simply. This 
> is very useful for planes and buses for example as we have the chance to 
> define all the seats as spots and are not required to make them fas. I have 
> modified the type of the field "accomNumber" to be of type short-varchar as 
> plane seats for example are mixture of letters and numbers(The book models it 
> of type numeric). The fk fields include the "nrOfSpaces" field in the book 
> which I have not included in my patch. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to