[ 
https://issues.apache.org/jira/browse/OFBIZ-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571455#action_12571455
 ] 

Bilgin Ibryam commented on OFBIZ-1634:
--------------------------------------

 If you wish to use the comment text you have typed (shown below), please copy 
it now. This text will be lost when you leave this screen.

What is the right place for jsessionid ? Before or after parameters ?

First I also thought that jsessionid is not inserted at the right place, but 
after looking at RequestHandler.makeLink:831 decided it work fine, because 
HttpServletResponse.encodeURL(String()) inserts jsessionid before 
"?param1=value1" and ofbiz code does the same here:

            if (response != null && !forceManualJsessionid && !isSpider) {
                encodedUrl = response.encodeURL(newURL.toString());
            } else {
                if (!isSpider){
                    String sessionId = ";jsessionid=" + 
request.getSession().getId();
                    // this should be inserted just after the "?" for the 
parameters, if there is one, or at the end of the string
                    int questionIndex = newURL.indexOf("?");
                    if (questionIndex == -1) {
                        newURL.append(sessionId);
                    } else {
                        newURL.insert(questionIndex, sessionId);
                    }
                }
                encodedUrl = newURL.toString();
            }

And also locally everything works w/o errors.


> Cannot review a product.
> ------------------------
>
>                 Key: OFBIZ-1634
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1634
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> http://demo.hotwaxmedia.com/ecommerce/control/product/~category_id=PROMOTIONS/~product_id=GZ-2644
> click on
> Be The First To Review This Product!
> login (i did as admin)
> get a blank page with this message
> Cannot review an unknown product.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to