+1 Scott
On 13/04/2008, Jacopo Cappellato <[EMAIL PROTECTED]> wrote: > > No feedback on this? > However, a committer should always be around to explain and provide > further details if there are concerns or questions on his commits. > > Should we revert this commit? > > Jacopo > > On Apr 9, 2008, at 4:29 AM, David E Jones wrote: > > > > > Actually, transactions ARE important for reading as well as writing, and > > should pretty much always be used. > > > > What was the problem you had that this change is supposed to solve? > > > > -David > > > > > > On Apr 8, 2008, at 5:21 PM, [EMAIL PROTECTED] wrote: > > > > > Author: sichen > > > Date: Tue Apr 8 16:21:14 2008 > > > New Revision: 646132 > > > > > > URL: http://svn.apache.org/viewvc?rev=646132&view=rev > > > Log: > > > turning off transactions for loading of cart from quote, since there > > > does not seem to be any data being stored, and having a transaction > > > consumes > > > resources unnecessarily and could cause it to fail if there are many items > > > on a quote > > > > > > Modified: > > > ofbiz/trunk/applications/order/servicedef/services_cart.xml > > > > > > Modified: ofbiz/trunk/applications/order/servicedef/services_cart.xml > > > URL: > > > http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/services_cart.xml?rev=646132&r1=646131&r2=646132&view=diff > > > > > > ============================================================================== > > > --- ofbiz/trunk/applications/order/servicedef/services_cart.xml > > > (original) > > > +++ ofbiz/trunk/applications/order/servicedef/services_cart.xml Tue > > > Apr 8 16:21:14 2008 > > > @@ -103,7 +103,7 @@ > > > </service> > > > > > > <service name="loadCartFromQuote" engine="java" auth="true" > > > - > > > location="org.ofbiz.order.shoppingcart.ShoppingCartServices" > > > invoke="loadCartFromQuote"> > > > + > > > location="org.ofbiz.order.shoppingcart.ShoppingCartServices" > > > invoke="loadCartFromQuote" use-transaction="false"> > > > <description>Create a ShoppingCart Object based on an existing > > > quote. If applyQuoteAdjustments is set to false then standard cart > > > adjustments are generated.</description> > > > <attribute name="quoteId" type="String" mode="IN" > > > optional="false"/> > > > <attribute name="applyQuoteAdjustments" type="String" mode="IN" > > > optional="true"/> > > > > > > > > > > > >
