[ 
https://issues.apache.org/jira/browse/OFBIZ-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604241#action_12604241
 ] 

Adrian Crum commented on OFBIZ-1839:
------------------------------------

This looks great!

Regarding the upper/lower case issue: if you look at current implementations of 
HTML element IDs, you'll see both styles being used. The lower case, dashed 
style is used in the main style sheet and in some screens where they are 
specified. On the other hand, the screen widgets generate HTML element IDs by 
using the widget's name - which is typically camel case. So, there is no rule - 
either style should be fine.

Maybe we could discuss this subject on the dev mailing list and come up with a 
best practice for it.


> Conversion of Screen Widget " Container to Screenlet" .
> -------------------------------------------------------
>
>                 Key: OFBIZ-1839
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1839
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: ConvertContainerToScreenlet.patch, 
> ConvertContainerToScreenlet.patch
>
>
> Remove the Container option from all the screen definition wherever possible 
> and put the screenlet  there.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to