[ 
https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605165#action_12605165
 ] 

Bruno Busco commented on OFBIZ-1841:
------------------------------------

Adrian,
thank you for your modifications, now the lookup works exactly the same as 
before if no change are done to the LookupScreens.
Great ! I have learned more about decorator sections from your modification.

I have seen that you also changed that the initial status of the search section 
of the lookup is not collapsed.
In my opinion the lookup table should appear to the user as just a table and 
the search part should be an option the user could use if needed. This is why I 
decided to use the collapsable functionality in lookups.
May be a drawback of having the search section initially collapsed is that it 
could never be accessed if scripting is disabled. But apart of this (and may be 
there is a workaround) I think it should better be collapsed.

What about the remaining patches? Are we ok to commit them? Or is there a 
different pattern we would better use?
Once we are sure of the pattern the lookupsceens should have I can move on 
changing all other files.

> Using collapsable screenlet in Lookups
> --------------------------------------
>
>                 Key: OFBIZ-1841
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1841
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Adrian Crum
>         Attachments: callapsable-lookupdecorator.patch, 
> order-newlookup.patch, party-newlookup.patch, product-newlookup.patch
>
>
> In the attached patch a new CollapsableLookupDecorator has been defined.
> With this decorator the lookup pops up with the search section collapsed and 
> with the elements list not filtered.
> The following lookups have been changed to use this new decorator:
> LookupProduct, LookupProductAndPrice, LookupProductCategory, 
> LookupProductFeature, LookupProductStore.
> If everybody is fine with the CollapsableLookupDecorator I will try to change 
> the other lookups also.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to