On Thu, 17 Jul 2008 17:45:26 +0200, Jacopo Cappellato <[EMAIL PROTECTED]> wrote: > > On Jul 17, 2008, at 5:34 PM, David E Jones wrote: > >> >> On Jul 17, 2008, at 9:28 AM, Jacopo Cappellato wrote: >> >>> Now that we have removed all the entitygroup.xml files containing >>> entity mappings for the org.ofbiz group (that is now assumed by >>> default), the method ModelGroupReader.getGroupNames() just return >>> the "org.ofbiz.olap" group. >>> What is the best way to fix this? Should we simply add the >>> "org.ofbiz" group to the list of groups? Or is there a more elegant >>> way of handling this? >> >> Yes, I missed that didn't I... >> >> The default-group-name should be added to the set that method returns. >> >> BTW, I noticed you made a change to compensate for this somewhere >> else, and I haven't had a chance to review that thoroughly, but >> changing this method may help with that problem too. >> > > Yes, my plan was actually to revert that change after this is fixed. > The only doubt I have is that in ModelGroupReader there is no > reference to a DelegatorInfo object (that contains the variable with > the default-group-name)... and I didn't want to move too many things.
We could probably just pass it in. It would change the method signature on the ModelGroupReader, but that's more of an internally used object anyway, so I wouldn't worry too much about it (actually I wouldn't bother worrying at all about it... ;) ). -David
