[ 
https://issues.apache.org/jira/browse/OFBIZ-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621787#action_12621787
 ] 

Bilgin Ibryam commented on OFBIZ-1910:
--------------------------------------

Ashish,

Thanks for your work. The patch looks fine to me. 

I'm not sure only about one point: when there is an entity modification 
proposal in the patch, should we also ask about it in the dev list, or waiting 
one week after jira issue is created is enough? Any suggestions?

Bilgin

> Add support of fromDate & thruDate in CustRequestRole entity
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1910
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1910
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>            Reporter: Ashish Vijaywargiya
>            Assignee: Ashish Vijaywargiya
>            Priority: Trivial
>         Attachments: Improve_CustRequestRole.patch, 
> Improve_CustRequestRole.patch
>
>
> Hello,
> I have added fromDate & thruDate field to maintain the old records from 
> CustRequestRole entity.
> Suppose a request is assigned to a party in the role of "Request Taker" and 
> after few day it can be assigned to another party in the role of "Request 
> Taker".
> So it will be easy to keep the old record with the help of fromDate & 
> thruDate.
> Please let me know your thoughts on it.
> --
> Ashish

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to