[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623567#action_12623567 ]
Bruno Busco commented on OFBIZ-1885: ------------------------------------ Tryed the updated patch and looks good to me. I suggest to put a width=320 height=200 to resize the image in the lookup. I have seen that now the VisualTheme can be selected using a button in the header (not colapsed) like for language and timezone. I think that all three selections should go in a User Preference screen defined in the framework as described in the Discussion thread in the ML. In the header (both standard sized and collapsed a simple profile link should take the user to its profile and preference settings. This is much more standard and will let us put mny other preference settings that otherwise will get the header more and more confused. -Bruno > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, > theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, > visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, > visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, > visualtheme_merged.patch, VisualThemeSelection.patch, > VisualThemeSelection.patch, vt_compactheader.zip > > > Implement entities, services, and UI artifacts to add support for selectable > Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.