[
https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626330#action_12626330
]
Jacques Le Roux commented on OFBIZ-1689:
----------------------------------------
Shi,
I did a 1st cursory review :
. You don't need to provide NOTICE and LICENCE file since there should be no
changes in them (you granted your right to ASF). BTW there is only one instance
of these files in root. They are now only copied by ant builds in jar files :
http://fisheye6.atlassian.com/qsearch/ofbiz/?q=notice
. Don't use tabs but 4 spaces in code, please *read*
http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
. I'm still not sure of ldap.jar licence, which one did you used ?
. Where may I find ofbiz-ldap.jar ?
. Please don't use absolut pathes like /usr/local/workspace/OFBiz4.0
Thanks for your work !
> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ofbiz4.0-ldap-patch-20080826.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
