[ https://issues.apache.org/jira/browse/OFBIZ-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630796#action_12630796 ]
David E. Jones commented on OFBIZ-1956: --------------------------------------- This is a great proof of concept Adrian, and I like the concept. I like how you've taken the concepts from the expression language and created a relational data structure. It's also nice that while an expression can be built up of sub-expressions and that any level of the expression can be referenced to determine if a time or time range intersects with the temporal expression. On a more important note, and why I called this a "proof of concept" is that the data structure don't tie back into anything in OFBiz yet. We need something more generic than a "schedule" because ideally this would tie into other event-like things such as a WorkEffort or JobSandbox record. Have you started looking at that yet? I'm thinking that the WorkEffort or JobSandbox could just point to a TemporalExpression instead of a RecurrenceRule, and there isn't really a need for the Schedule entity. And actually with the heavy overlap between Schedule and WorkEffort I think Schedule is fine for a PoC but shouldn't be actually added to the project (I don't know if that was your intent or not, I'm just expressing that). > Improved Recurring Events > ------------------------- > > Key: OFBIZ-1956 > URL: https://issues.apache.org/jira/browse/OFBIZ-1956 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Priority: Minor > Attachments: Calendar.patch > > > Come up with an improved recurring event implementation. Details in comments. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.