[ 
https://issues.apache.org/jira/browse/OFBIZ-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640173#action_12640173
 ] 

Rishi Solanki commented on OFBIZ-2000:
--------------------------------------

Surya, Kirti, and Onima,

Your work is absolutely working as per requirement.

Here are few improvements which need to be rectified before it goes into trunk.
 - You have included CustomerScreens.xml in the patch (No need to include it in 
your patch)
 - The uiLabel you created in the EcommerceUiLabel.xml is 
"CommonCheckAvailability" we generally prefer the Component name as prefix. 
Like "EcommerceCheckAvailability".
 - in the request you have use to go for secured port, there is no need to send 
this request at secured port.
 - In checkAvailableUserName function in JS there is need some indentation 
fixes.
 - Finally we need to remove the link and can call the Ajax.Request on change 
event of  username.

Do the needful and upload the patch ASAP.
For me you all have done a great job.

-- Regards
Rishi Solanki


> Added check availability functionality on new create profile page of e 
> commerce.
> --------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2000
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2000
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>            Reporter: Rishi Solanki
>            Priority: Minor
>         Attachments: CheckAvailUserName.patch
>
>
> After adding this functionality while creating a profile from e commerce new 
> profile pages, user will be able to check his/her selected userLoginId is 
> availabel or not. Instead after submitting the whole form can check it just 
> by clicking on a check availability link. For this implementation can use 
> Ajax.request for submitting the user name and finally getting back the error 
> list from the server. If got the error appear it else hide.
> Affected files for this feature are ;
> CustomerEvents.xml ----> ecommerce
> profile.js ---> ecommerce
> NewCustomer.ftl ---> ecommerce (for new one)
> Regards
> - Rishi Solanki

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to