I will do as requested next time.

I used the  "load the payment infos" that was below where my patch went
as my guide.

The preferred style would have been?

for (GenericValue orderAttr : orderAttributesList)
{
    String name = orderAttr.getString("attrName");
    String value = orderAttr.getString("attrValue");
    cart.setOrderAttribute(name, value);
}


Jacques Le Roux (JIRA) wrote:
>      [ 
> https://issues.apache.org/jira/browse/OFBIZ-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>  ]
>
> Jacques Le Roux closed OFBIZ-2085.
> ----------------------------------
>
>     Resolution: Fixed
>       Assignee: Jacques Le Roux
>
> Stephen,
>
> Your patches are in trunk revision: 727112  
>
> But please use java 1.5 feature (new for loop style, genericization in 
> general) and read OFBiz Contributors Best Practices...
>
>   
>> ShoppingCartServices.loadCartFromOrder
>> --------------------------------------
>>
>>                 Key: OFBIZ-2085
>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2085
>>             Project: OFBiz
>>          Issue Type: Improvement
>>          Components: order
>>    Affects Versions: SVN trunk
>>         Environment: Windows XP
>>            Reporter: Stephen Rufle
>>            Assignee: Jacques Le Roux
>>             Fix For: SVN trunk
>>
>>         Attachments: 002_ShoppingCartServices.patch, 
>> 003_ShoppingCartServices.patch, 003_ShoppingCartServices.patch
>>
>>
>> When loading a ShoppingCart  from a previously saved order it should also 
>> retrieve any  OrderAttribute's and OrderItemAttribute's
>>     
>
>   

-- 
Stephen P Rufle
[email protected]
H1:480-626-8022
H2:480-802-7173
Yahoo IM: stephen_rufle
AOL IM: stephen1rufle

Reply via email to