You should not have any tabs in files but 4 spaces (but in FTL files where 2
spaces is better)
Just read
http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
Thanks
Jacques
From: "guo weizhan" <guo.weiz...@gmail.com>
Yeah, I saw braces missed
but what's wrong about the tabs? I don't know about this, if you can tell me
I can do better next time :D
2008/12/30 Jacques Le Roux (JIRA) <j...@apache.org>
[
https://issues.apache.org/jira/browse/OFBIZ-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659775#action_12659775]
Jacques Le Roux commented on OFBIZ-2108:
----------------------------------------
Lines 57 & 59 of your patch, exactly where the braces missed ;)
> The bug using IN operator with FindServices.java
> ------------------------------------------------
>
> Key: OFBIZ-2108
> URL: https://issues.apache.org/jira/browse/OFBIZ-2108
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: WeizhanGuo
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: FindServices_IN.patch
>
>
> I want search all the OrganId is 0001 or 0002, and use the
performFindList service.
> So I set the value like this:pfInput.inputFields.OrganId_fld0_op=in and
pfInput.inputFields.OrganId_fld0_value=0001,0002 and invoke the service, the
generate where SQL is "OrganId in ('0001,0002') " but what I want is
"OrganId in ('0001','0002')."
> if I pass the list value to the pfInput.inputFields.OrganId_fld0_value,
the createCondtion don't support value as list type. and the method of
convertFieldValue will convert the list to String, that's more complex.
> I created a patch, let the value accept the list and if the operator is
in ignore the convertFieldValue.
> Please let me know if there is any problem
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
