Vikas
On Feb 8, 2009, at 2:55 AM, Jacques Le Roux wrote:
Thanks for the pointer Scott! Done in revision: 741964I checked the only other mutiple select (for *.ftl) is in Product/ QuickAdmin, and this change solves also an issue there (visible before this commit in FF3 also)Jacques From: "Scott Gray" <scott.g...@hotwaxmedia.com>Hi Jacques,I don't think 584 occurrences of a practice which is agreed by all to be bad makes a good argument for having 585 :-)Besides it should just be a matter of adding something like: select[multiple="multiple"] { height: 5em; } below the current select selector in maincss.css Regards Scott HotWax Media http://www.hotwaxmedia.com 801.657.2909 ----- Original Message ----- From: "Jacques Le Roux" <jacques.le.r...@les7arts.com> To: dev@ofbiz.apache.orgSent: Saturday, February 7, 2009 1:18:06 PM GMT -07:00 US/Canada Mountain Subject: Re: svn commit: r741948 - /ofbiz/trunk/applications/order/ webapp/ordermgr/order/findOrders.ftlHi Scott,Yes, I thought the same. Then I searched in *.ftl and find 584 occurences of the same type (style="). And I thought also that addinga style for this only case was a bit too much...Of course if there is already a such style I'm ready to improve. Or if we knew where there should the same be apllied, then we couldgeneralize... Jacques From: "Scott Gray" <scott.g...@hotwaxmedia.com>Hi Jacques http://docs.ofbiz.org/display/OFBADMIN/HTML+and+CSS+Best+Practices"HTML should be well structured, concise, and free of styling information. Well structured HTML is easily styled with style sheets (CSS) - therefore all styling code should be kept in the style sheets."Regards Scott HotWax Media http://www.hotwaxmedia.com 801.657.2909 ----- Original Message ----- From: jler...@apache.org To: comm...@ofbiz.apache.orgSent: Saturday, February 7, 2009 12:58:29 PM GMT -07:00 US/Canada Mountain Subject: svn commit: r741948 - /ofbiz/trunk/applications/order/ webapp/ordermgr/order/findOrders.ftlAuthor: jleroux Date: Sat Feb 7 19:58:28 2009 New Revision: 741948 URL: http://svn.apache.org/viewvc?rev=741948&view=rev Log:A patch from Sumit Porwal "On find orders form, user can not select multiple Role Types however the "findOrders" service supportsit." (https://issues.apache.org/jira/browse/OFBIZ-2136) - OFBIZ-2136 Modified:ofbiz/trunk/applications/order/webapp/ordermgr/order/ findOrders.ftlModified: ofbiz/trunk/applications/order/webapp/ordermgr/order/ findOrders.ftlURL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/order/findOrders.ftl?rev=741948&r1=741947&r2=741948&view=diff= = = = = = = = = = ==================================================================== --- ofbiz/trunk/applications/order/webapp/ordermgr/order/ findOrders.ftl (original) +++ ofbiz/trunk/applications/order/webapp/ordermgr/order/ findOrders.ftl Sat Feb 7 19:58:28 2009@@ -132,7 +132,7 @@<td width='25%' align='right' class='label'>$ {uiLabelMap.PartyRoleType}</td><td width='5%'> </td> <td align='left'> - <select name='roleTypeId'>+ <select name='roleTypeId' multiple="multiple" style="height:5em"><#if currentRole?has_content><option value="${currentRole.roleTypeId}">$ {currentRole.get("description", locale)}</option> <option value="${currentRole.roleTypeId}">---</ option>
smime.p7s
Description: S/MIME cryptographic signature
