[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681350#action_12681350 ]
Pranay Pandey edited comment on OFBIZ-2220 at 3/12/09 8:15 AM: --------------------------------------------------------------- Hello Deepesh, I reviewed your patch. Here are my comments for improvements: # Update the patch to OFBiz head. # UiLabel cancelBackOrderDate should be FormFieldTitle_ cancelBackOrderDate # In OrderView.groovy, first find list of orderItems then do getfirst on the list instead giving a hardcoded value for orderItemSeqId. # In ShoppingCartServices.java we don't need to do cart.setCancelBackOrderDate(cartShipGroupIndex, sg.getTimestamp("cancelBackOrderDate")); as this is not related to shipgroup. # <field name="cancelBackOrderDate" type="date-time"></field> doesn't need to be there in "OrderItemShipGroup" entity. # Improve the short-description in the service implementation for cancelAllBackOrders, it should be "Cancels all back orders from supplier" # Check in CheckOutHelper.java do we really need to have this field in methods setCheckOutShippingOptions and setCheckOutShippingOptionsInternal(No need to set this field for shipping options) # Also Check setter and getter methods for cancelBackOrderDate. Also check for the unused code thats not needed and upload the updated patch. was (Author: pandeypranay): Hello Deepesh, I reviewed your patch. Here are my comments for improvements: # Update the patch to OFBiz head. # UiLabel cancelBackOrderDate should be FormFieldTitle_ cancelBackOrderDate # In OrderView.groovy, first find list of orderItems then do getfirst on the list instead giving a hardcoded value for orderItemSeqId. # In ShoppingCartServices.java we don't need to do cart.setCancelBackOrderDate(cartShipGroupIndex, sg.getTimestamp("cancelBackOrderDate")); as this is not related to shipgroup. # <field name="cancelBackOrderDate" type="date-time"></field> doesn't need to be there in "OrderItemShipGroup" entity. # Improve the short-description in the service implementation for cancelAllBackOrders, it should be "Cancels all back orders from supplier" # Check in CheckOutHelper.java do we really need to have this field in methods setCheckOutShippingOptions and setCheckOutShippingOptionsInternal(No need to set this field for shipping options) # Also Check setter and getter methods for cancelBackOrderDate. Also check for the unused code thats not needed and upload the updated patch. > Add new field for "Cancel Back Orders Date", like others for OrderItem. Show > these on Purchase order PDF. > --------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-2220 > URL: https://issues.apache.org/jira/browse/OFBIZ-2220 > Project: OFBiz > Issue Type: Sub-task > Components: order > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Priority: Minor > Fix For: SVN trunk > > Attachments: ofbiz-2220.patch, ofbiz-2220.patch > > > There should be one field "cancelBackOrdersDate" associated with order items > which will help to cancel those orders which have crossed this date. > *Implementation Notes:* > Add new field for cancelBackOrdersDate", like others for OrderItem. Show on > Purchase Order PDF. > Add a service to look at all purchase orders with the field set and if the > date is in the past then it should cancel those orders; the service should > run on a schedule, once per day. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.