[
https://issues.apache.org/jira/browse/OFBIZ-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682239#action_12682239
]
Jacques Le Roux commented on OFBIZ-2239:
----------------------------------------
Hi Divesh,
I just did a cursory review of your patch, some remarks:
* please use preferably FastList than LinkedList
* please use preferably new for loop (1.5) style instead of iterator (even if
current code around still uses iterator)
* dont put any tabs in your code but 4 spaces (2 in .ftl, please be sure to
check [Contributors Best
Practices|http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices])
Thanks
> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for
> order items
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-2239
> URL: https://issues.apache.org/jira/browse/OFBIZ-2239
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: Ofbiz-2239.patch
>
>
> Functionality for putting in estimatedShipDate and estimatedDeliveryDate for
> order items and shipgroup.
> After placing purchase order supplier can give estimatedShipDate and
> estimatedDeliveryDate to the buyer which can be entered by the buyer in the
> order detail page for the orderItems, which will be saved in OrderItem and
> OrderItemShipGroup with last date amongst them.
> *Implementation Notes:*
> Add UI in order detail to specify estimated ship dates (put in
> OrderItem.estimatedShipDate, OrderItem.estimatedDeliveryDate; consider adding
> similar fields to OrderItemShipGroup with the last date amongst them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
