[ 
https://issues.apache.org/jira/browse/OFBIZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683001#action_12683001
 ] 

Pranay Pandey edited comment on OFBIZ-2221 at 3/18/09 5:14 AM:
---------------------------------------------------------------

Thanks Akash for providing patch for this issue.

I reviewed and tested your patch there are few places that needs improvement:

#  After adding items to PO leaves a cart in place that causes problem when we 
go back to order entry screen. You can handle this in your event.
#  No need to create shopping cart object in your event as its not being used 
anywhere and the called service is handling it.
#  There are few more objects which are created but not being used, remove 
unused code.
#  Also the functionality to add a single product to the order is not working 
after applying the patch as orderId is not found in OrderView.groovy, correct 
this as well.

      was (Author: pandeypranay):
    Thanks Akash for providing patch for this issue.

I reviewed and tested your patch there are few places that needs improvement:

#  After adding items to PO leaves a cart in place that causes problem when we 
go back to order entry screen.
    You can handle this in your event.

#  No need to create shopping cart object in your event as its not being used 
anywhere and the called service is handling it.

#  There are few more objects which are created but not being used, remove 
unused code.

#  Also the functionality to add a single product to the order is not working 
after applying the patch as orderId is not found in OrderView.groovy, correct 
this as well.
  
> Functionality to add more then one product at a time to purchase order in 
> order detail page
> -------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2221
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2221
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2221.patch, OFBIZ-2221.patch
>
>
> Provide functionality to add more then one product at a time to purchase 
> order in order detail page.
> *Implementation Notes:*
> Add multi-add form to Order Manager order detail page, at bottom with single 
> add item form.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to