[ https://issues.apache.org/jira/browse/OFBIZ-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693978#action_12693978 ]
David E. Jones commented on OFBIZ-2259: --------------------------------------- This looks pretty good in general. One small issue: it is not thread safe. At some point we may decide that running test suites one at a time is too slow. In other words, chances are running a few at a time will result in an over all performance increase compared to running them in serial. One way we could possibly do this is to clone the delegator and use one instance per test suite. That's the first that comes to mind anyway, there are probably better options... A ThreadLocal variable is something I always consider to be a bit of a hack, but they do have their place. In this case that might not work as a test case could have multiple threads (not sure if any do...). > Testing - Rollback database changes after each test-suite using the > GenericDelegator > ------------------------------------------------------------------------------------ > > Key: OFBIZ-2259 > URL: https://issues.apache.org/jira/browse/OFBIZ-2259 > Project: OFBiz > Issue Type: New Feature > Components: framework > Reporter: Scott Gray > Assignee: Scott Gray > Attachments: rollback.patch > > > During testing have the delegator keep track of all changes made to the > database and then roll them back at the end of each test suite. This will > allow the same demo data to be reused across test suites without having to > worry about what changes previous tests have made to the data and solves this > problem regardless of the database being used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.