Adam Heath wrote:
> jone...@apache.org wrote:
>> Author: jonesde
>> Date: Tue Mar 24 06:27:03 2009
>> New Revision: 757671

I've had a chance to look over this change, the removal of
WebAppDispatcher.  And, it could break some code.

WebAppDispatcher has a check for a null classloader; if so, it uses
the Thread's classloader.

However, the standard GenericDispatcher does *not* do this; instead,
it uses the classloader of GenericDispatcher.class.

So, I consider this change to actually introduce a *regression*, even
if it doesn't actually cause any bugs in ofbiz trunk.

Additionally, ofbiz maintains a global cache of dispatchers by name.
This is a big nono for webslinger.  Webslinger has a *single* lookup
point, and then everything else it uses is keyed off of that.  This
allows for recycling to be done, by just removing the top-level reference.

Reply via email to