[ https://issues.apache.org/jira/browse/OFBIZ-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700145#action_12700145 ]
Ashish Vijaywargiya commented on OFBIZ-2297: -------------------------------------------- Hello Marco, Thanks for working on this. I have reviewed your patch and it looks almost good. One change that I would like to see before committing it to trunk. Instead of "EditGatewayConfig" we should use "EditPaymentGatewayConfig". And same applies to other places (request, service definition & implementation for other) This helps to easily identify the name of entity if we exclude prefix that we use in general. For ex : Update, Edit, Create, Delete etc. Let's see what other has to say on this. If others are fine then you can go ahead and commit the code. Thanks ! -- Ashish Vijaywargiya > Misc improvements on Payment Gateway Config > ------------------------------------------- > > Key: OFBIZ-2297 > URL: https://issues.apache.org/jira/browse/OFBIZ-2297 > Project: OFBiz > Issue Type: Improvement > Components: accounting > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Attachments: MiscImprPaymentGateway.patch > > > 1) encrypt passwords. > 2) service names changed. > 3) request map entries changed. > 4) now the Payment Gateway Config menu is visible only to user having > PAYPROC_ADMIN permission. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.