Re: Codes

[Jacques Le Roux]

Hi Andrew,

From: "Andrew Zeneski" <andrew.zene...@hotwaxmedia.com>
I think this is due to the new HTML security, but now we have these  "&#160;" codes floating all over the place. I'm not sure what 
the best  solution for this is, but I thought I would check in a change like this:

This is not as simple. I agree it's a quick fix for the issue at hand. But this is due to Labels Manager. If you put a sole space 
(ie > < ) then if you do some modifications with Labels Manager in this file and then save in the file you will get
   <property key="CommonEmptyHeader">
       <value xml:lang="en"/>
   </property>

In order to cope with this I tried to write directly at SaveLabelsToXmlFile.saveLabelsToXmlFile[93] the String "&#160;" which should 
be ok. But I guess I would have to change the format passed to UtilXml.writeXmlDocument some lines below since else it write 
"&amp;#160;" and not "&#160;" as intended. Not sure it's possible though. And I have no time to look at it right now.

So I made the change you proposed at r767845  and  r767848  for R9.04
And we will have to deal with that in a complete way since else we will find an even worst trouble later (as soon someone will use 
Labels Manager to save changes in this file)

Jacques


I had some zele here (ok not only here ;o)

Index: config/CommonUiLabels.xml
===================================================================
--- config/CommonUiLabels.xml (revision 767649)
+++ config/CommonUiLabels.xml (working copy)
@@ -1997,7 +1997,7 @@
         <value xml:lang="zh_CN">电子邮件</value>
     </property>
     <property key="CommonEmptyHeader">
-        <value xml:lang="en">&amp;#160;</value>
+        <value xml:lang="en"> </value>
     </property>
     <property key="CommonEnabled">
         <value xml:lang="ar">شغال</value>

Any thoughts???


Andrew