[
https://issues.apache.org/jira/browse/OFBIZ-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703134#action_12703134
]
Jacopo Cappellato commented on OFBIZ-2205:
------------------------------------------
Abhinav, Ashish,
thanks for your work and review, they are both very appreciated.
I would like to add mine comments after reviewing the data model part of this
patch:
1) instead of "approverId" I would suggest "approverPartyId"; also, wouldn't be
better to define the fk to the Party entity (instead of the Person entity)?
2) InterviewInformation:
2a) woudn't be better to name it just "Interview" or even better
"JobInterview"? (but if we choose "JobInterview" then we shoudl add the job
prefix to some of its fields for consistency)
2b) should gradeSecured, result be associated to the Enumeration entity (and
renamed to gradeSecuredEnumId etc..)?
2c) intervieweeId and interviewerId should be intervieweePartyId and
interviewerPartyId and associated to the Party entity (not Person entity)
3) Exam: I think we can use the Enumeration entity instead of a new entity; or
at least we should rename it as "ExamType"
4) what is the purpose of the JobPostingType entity? sorry, I can't understand
it from the context (in general, what is a "job posting"?)
5) EmployeeAction: I am not 100% sure about the meaning of this entity but
maybe instead of it we could use the EmplPosition and EmplPositionFulfillment
entities (I suspect that they model the same exact data)
Cheers,
Jacopo
> Implemented recruitment in HR module
> ------------------------------------
>
> Key: OFBIZ-2205
> URL: https://issues.apache.org/jira/browse/OFBIZ-2205
> Project: OFBiz
> Issue Type: New Feature
> Components: humanres
> Affects Versions: SVN trunk
> Environment: Windows XP Professional (5.1, Build 2600) Service Pack
> 2, Intel(R) Core(TM)2 CPU 4300 @ 1.80GHz (2 CPUs), 1014MB RAM, jdk1.5.0,
> apache-ant-1.7.0
> Reporter: Abhinav Vaid
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: HR_Recruitment.patch, HR_Recruitment.patch,
> HR_Recruitment.patch, HR_Recruitment.patch, HR_Recruitment.patch,
> HR_Recruitment.patch
>
>
> In this patch we have included recruitment in the HR module.
> Recruitment performs tasks such as admin can create new job requisitions.
> He can update or delete new job requisitions.
> Now once the job requisition has been added, it is visible to all the
> employees.
> Then if interested employee wants to apply for the job requisition he sends
> it for approval to his superior.
> Superior from his login can check who all have applied for job requisition.
> He can update the status and same is reflected at employee's end.
> Here admin can also create new interview types and he can store the
> information of the diffrent interviews of employees.
> We have created Security groups:
> HUMANRES_APPROVER
> HUMANRES_EMPLOYEE
> We have created Security permissions:
> HUMANRES_APPROVE
> We have created Login Id's :
> demoadmin belongs to FULLADMIN security group
> demoapprover belongs to HUMANRES_APPROVER security group
> demoemployee belongs to HUMANRES_EMPLOYEE security group
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
