Initially, it started out as a bug fix. We began by simply trying to fix all of the issues with Smoothfeather that were listed in various JIRA issues, but as we went along it became more and more apparent that although the design was good, the original markup was not. We ended up having to touch so many files that it became much easier to simply start fresh rather than have a patch that was 2000 lines long, or a series of patches that were cumbersome and confusing to manage. So in summary:

Was a bug fix...
Now a new feature.

Ryan Foster
HotWax Media
801.671.0769
ryan.fos...@hotwaxmedia.com




On May 3, 2009, at 3:51 AM, Adrian Crum wrote:


From what I understand, the Smoothfeather theme is broken, and instead of fixing it, it is being replaced by a new theme. If that's the case, and the new theme is the default and the one that will be maintained, then we should probably make that change in the release too.

Yes, it looks like a new feature. But from another perspective it could be a bug fix.

-Adrian


--- On Sat, 5/2/09, David E Jones <david.jo...@hotwaxmedia.com> wrote:

From: David E Jones <david.jo...@hotwaxmedia.com>
Subject: Re: svn commit: r770998 - in /ofbiz/branches/ release09.04: ./ themes/bizznesstime/ themes/bizznesstime/data/ themes/bizznesstime/includes/ themes/bizznesstime/webapp/ themes/ bizznesstime/webapp/bizznesstime/ themes/bizznesstime/webapp/ bizznesstime/WEB-INF/...
To: dev@ofbiz.apache.org
Date: Saturday, May 2, 2009, 8:50 PM
This looks a lot more like a new feature than a bug fix to
me.

I think Jacques is clearly voting for it being a bug fix.

Does anyone else have a vote/opinion?

-David


On May 2, 2009, at 5:37 PM, jler...@apache.org wrote:

Author: jleroux
Date: Sat May  2 23:08:44 2009
New Revision: 770998

URL:
http://svn.apache.org/viewvc?rev=770998&view=rev
Log:
"Applied fix from trunk for revision: 770997
"

------------------------------------------------------------------------
r770997 | jleroux | 2009-05-03 01:05:29 +0200 (dim.,
03 mai 2009) | 1 line

New BizznessTime Theme which should be soon replacing
SmoothFeather. Please test, report and see more at
https://issues.apache.org/jira/browse/OFBIZ-2398

------------------------------------------------------------------------


Added:
  ofbiz/branches/release09.04/themes/bizznesstime/
    - copied from r770997,
ofbiz/trunk/themes/bizznesstime/

ofbiz/branches/release09.04/themes/bizznesstime/data/
    - copied from r770997,
ofbiz/trunk/themes/bizznesstime/data/

ofbiz/branches/release09.04/themes/bizznesstime/data/ bizznessTimeThemeData.xml
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/data/bizznessTimeThemeData.xml

ofbiz/branches/release09.04/themes/bizznesstime/includes/
    - copied from r770997,
ofbiz/trunk/themes/bizznesstime/includes/

ofbiz/branches/release09.04/themes/bizznesstime/includes/appbar.ftl
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/includes/appbar.ftl

ofbiz/branches/release09.04/themes/bizznesstime/includes/footer.ftl
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/includes/footer.ftl

ofbiz/branches/release09.04/themes/bizznesstime/includes/header.ftl
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/includes/header.ftl

ofbiz/branches/release09.04/themes/bizznesstime/includes/messages.ftl
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/includes/messages.ftl

ofbiz/branches/release09.04/themes/bizznesstime/includes/secondary- appbar.ftl
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/includes/secondary-appbar.ftl

ofbiz/branches/release09.04/themes/bizznesstime/ofbiz-component.xml
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/ofbiz-component.xml

ofbiz/branches/release09.04/themes/bizznesstime/webapp/
    - copied from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/
    - copied from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ WEB-INF/
    - copied from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/WEB-INF/

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ WEB-INF/web.xml
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/WEB-INF/web.xml

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ css/
    - copied from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/css/

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ css/forms.css
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/css/forms.css

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ css/ie.css
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/css/ie.css

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ css/legacy.css
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/css/legacy.css

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ css/links.css
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/css/links.css

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ css/login.css
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/css/login.css

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ css/print.css
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/css/print.css

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ css/style.css
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/css/style.css

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/
    - copied from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/ajax-loader.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/ajax- loader.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/app-bar-bg.jpg
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/app-bar- bg.jpg

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/app-selected-yella.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/app- selected-yella.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/background.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/ background.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/bg.jpg
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/bg.jpg

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/bkg-nav.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/bkg- nav.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/bkg-search-2.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/bkg- search-2.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/btn-bg.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/btn-bg.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/close.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/close.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/divider.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/ divider.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/divider.png
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/ divider.png

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/footer-shelf.jpg
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/footer- shelf.jpg

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/footer.jpg
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/footer.jpg

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/header-down.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/header- down.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/header-up.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/header- up.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/icons/
    - copied from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/icons/

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/icons/doc.png
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/icons/ doc.png

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/icons/email.png
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/icons/ email.png

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/icons/external.png
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/icons/ external.png

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/icons/feed.png
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/icons/ feed.png

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/icons/icon-minus.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/icons/ icon-minus.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/icons/icon-plus.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/icons/ icon-plus.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/icons/im.png
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/icons/ im.png

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/icons/pdf.png
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/icons/ pdf.png

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/icons/visited.png
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/icons/ visited.png

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/icons/xls.png
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/icons/ xls.png

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/login-logo.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/login- logo.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/logo.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/logo.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/page.png
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/page.png

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/shelf.jpg
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/shelf.jpg

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/slide-button-active.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/slide- button-active.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/slide-button.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/slide- button.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/tab-round.png
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/tab- round.png

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/tableheader-bg.jpg
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/ tableheader-bg.jpg

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/wl.png
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/wl.png

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/wr.png
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/wr.png

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ images/wrapper-bg.jpg
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/images/wrapper- bg.jpg

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ js/
    - copied from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/js/

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ js/application.js
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/js/application.js

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ ofbiz.gif
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/ofbiz.gif

ofbiz/branches/release09.04/themes/bizznesstime/webapp/bizznesstime/ screenshot.jpg
    - copied unchanged from r770997,
ofbiz/trunk/themes/bizznesstime/webapp/bizznesstime/screenshot.jpg
Modified:
  ofbiz/branches/release09.04/   (props changed)

Propchange: ofbiz/branches/release09.04/

------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Sat May  2 23:08:44 2009
@@ -1 +1 @@

-/ofbiz/trunk: 765933,766011,766015,766293,766307,766316,766325,766462,766522,766800,767060,767072,767093,767098-767099,767102,767123,767125,767127,767279,767287,767671,767688,767694,767822,767845,768358,768490,768550,768675,768686,768705,768811,768815,768960,769030,769500,770272

+/ofbiz/trunk: 765933,766011,766015,766293,766307,766316,766325,766462,766522,766800,767060,767072,767093,767098-767099,767102,767123,767125,767127,767279,767287,767671,767688,767694,767822,767845,768358,768490,768550,768675,768686,768705,768811,768815,768960,769030,769500,770272,770997






Reply via email to