>>but it may be worth keeping in mind that every additional requirement we place on contributors could see the number of contributions reduced.
I don't think that it will or can reduce the contributions. Even if the developer is smart enough and passionate to do good work then he / she will encourage the use of most of the best practice IMO. Keeping best practice at common place doesn't mean that we should take your contribution only if it is abide by all the points specified on the best practice page. Consider other side like if developer don't follow the best practice although we are here to accept the patch and do so. So defining things at common place (i.e Best Practices) attracts the targeted audience IMO. -- Ashish On Wed, May 20, 2009 at 6:17 PM, Scott Gray <[email protected]>wrote: > I think it's fine as a suggestion, but it may be worth keeping in mind that > every additional requirement we place on contributors could see the number > of contributions reduced. The contributors best practice page is already > quite long and the longer it gets the less likely people are to read the > whole thing or to read the important parts as thoroughly as they might have. > I don't mind either way but it's worth keeping in mind. > > Personally I never even download patches, I just open them in the browser, > copy the text and then use apply patch from clipboard in eclipse. It means > I'm always guaranteed to be using the latest patch and I don't end up a mess > of patches on my machine. > > Regards > Scott > > >
