[ 
https://issues.apache.org/jira/browse/OFBIZ-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714119#action_12714119
 ] 

Ryan Foster commented on OFBIZ-2543:
------------------------------------

That makes sense to me, but why do we have a function in 
HtmlScreenRenderer.java that reads:

public void renderScreenBegin(Appendable writer, Map<String, Object> context) 
throws IOException {
        writer.append("<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 
Transitional//EN\" 
\"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\";>");
        appendWhitespace(writer);
}

and then in htmlScreenMacroLibrary.ftl we have:

<#macro renderScreenBegin>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" 
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
</#macro>

If the function is already writing it in, then why are we also calling it 
inside the function that should be writing it in already?  Shouldn't it be one 
or the other?

> Multiple DOCTYPE in rendered HTML
> ---------------------------------
>
>                 Key: OFBIZ-2543
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2543
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Ryan Foster
>            Assignee: Anil K Patel
>            Priority: Minor
>         Attachments: Picture 1.JPG, Picture 2.JPG, Picture 3.JPG
>
>
> The XHTML Transitional DOCTYPE is being duplicated for each screen definition 
> when each view is rendered in HTML.
> Looked into this a bit and it looks like the  <!DOCTYPE html PUBLIC 
> "-//W3C//DTD XHTML 1.0 Transitional//EN" 
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";> DOCTYPE 
> declaration is being called in multiple files:
> 1. In HtmlScreenRenderer.java at line 75
> 2. In htmlScreenMacroLibrary.ftl at line 21
> 3. In headerHead.ftl at line 19 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to