[ 
https://issues.apache.org/jira/browse/OFBIZ-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722475#action_12722475
 ] 

Adrian Crum commented on OFBIZ-2532:
------------------------------------

Harmeet,

I really appreciate your interest in contributing to the project. We could use 
all the help we can get! It takes some patience to become a good contributor. 
All of us had to go through a learning process - a process that might have 
included rejected patches. I said all of that because I don't want you to 
become discouraged.

Now, let's step back for a moment and take an honest look at this Jira issue. 
It's about compiler deprecation warnings. Deprecation warnings are not bugs, 
they are not critical, and the world won't come to an end because of them. They 
are simply stating "something that exists today might not exist in the future." 
From a developer's perspective, they are a minor annoyance.

Your solution to this annoyance is to remove framework methods that hundreds of 
OFBiz installations might be counting on. My solution is to deprecate those 
framework methods, and encourage the OFBiz developers to update the 
applications to use the newer methods, plus give the user base time to update 
their modifications that use those methods.

I found 7 references to the deprecated Xerces class - 
org.apache.xml.serialize.OutputFormat. Those references need to be fixed, and 
they need to be tested. As I stated at the start, those references should be 
utilizing the new UtilXml JAXP TrAX methods or DOM 3 methods - so situations 
like this don't happen in the future.

What I said earlier still stands. If you want to contribute a patch, then 
contribute a patch that fixes the applications, not UtilXml.


> Deprecated warning for xerces
> -----------------------------
>
>                 Key: OFBIZ-2532
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2532
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Harmeet Bedi
>            Assignee: Adrian Crum
>             Fix For: SVN trunk
>
>         Attachments: CCPaymentServices.java.diff, UtilXml.diff
>
>
> Build looks ugly with these. 
> 2 spots are CCPaymentServices and UtilXml
> Attaching svn diff patch for those.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to