[ 
https://issues.apache.org/jira/browse/OFBIZ-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743824#action_12743824
 ] 

Jacques Le Roux commented on OFBIZ-2374:
----------------------------------------

Hi Vadiraj,

Firts of all, thanks for your works!

I did a 1st and cursory review (no tests), here are some remarks

framework/appserver/templates/glassfish21/entityengine.xml.patch
ASL2 licence header missing
port:1527 nothing about at 
http://docs.ofbiz.org/display/OFBIZ/Glassfish+v2.1+deployment

framework/appserver/templates/glassfish21/application.xml
ASL2 licence header missing

framework/appserver/templates/glassfish21/deploy.sh
ASL2 licence header missing

framework/appserver/templates/glassfish21/domain.xml
ASL2 licence header missing
What about 
+<!--
+   Copyright 1997-2007 Sun Microsystems, Inc.  All rights reserved.
+   Use is subject to license terms.
+-->
?

framework/appserver/templates/glassfish21/run.sh
ASL2 licence header missing

framework/appserver/templates/glassfish21/README
ASL2 licence header missing


When later I will commit your work I will move 
http://docs.ofbiz.org/display/OFBIZ/Glassfish+v2.1+deployment to 
http://docs.ofbiz.org/display/OFBTECH/Run+OFBiz+under+outside+Application+Servers

I think I will commit as is since it can not make any troubles. And then if 
people are interested you will receive questions and maybe support demands

> OFBiz deployment on Glassfish v2.1
> ----------------------------------
>
>                 Key: OFBIZ-2374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2374
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>         Environment: All platforms and Operating systems on which OFBiz is 
> known to run.
>            Reporter: Vadiraj Deshpande
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: glassfish21.patch, glassfish21.patch, glassfish21.patch
>
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> First class Galssfish support for OFBiz is a required feature. For anyone who 
> wants to use OFBiz with Glassfish, there should be easy way to generate 
> configuration files and OFBiz should get deployed well on the server. This 
> support should match or exceed the OFBiz support for other Java EE servers 
> such as JBoss.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to