[ https://issues.apache.org/jira/browse/OFBIZ-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744390#action_12744390 ]
Jacques Le Roux commented on OFBIZ-2838: ---------------------------------------- Hi Al, IMO yes, what would mean an empty login ? > ServiceUtil.getUserLogin tests on null but not empty > ---------------------------------------------------- > > Key: OFBIZ-2838 > URL: https://issues.apache.org/jira/browse/OFBIZ-2838 > Project: OFBiz > Issue Type: Bug > Components: framework > Reporter: Al Byers > > Line 587 in ServiceUtil.getUserLogin is: > if (runAsUser != null) { > but i got an empty string passed in. > Should use UtilValidate.isNotEmpty? > I could change it, but I don't think I have ever touched core code and don't > wish to start. > -Al -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.