[ 
https://issues.apache.org/jira/browse/OFBIZ-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744828#action_12744828
 ] 

Bob Morley commented on OFBIZ-2778:
-----------------------------------

That is a good document in the FAQ, but I am not sure how it applies.  In this 
bug I am not really changing any functionality really just refactoring the JSON 
functionality and reducing code.  My first inkling is to leave this 
functionality as a java method because (I think) the benefits of ftl don't 
really apply.  Moreover, there is nothing here that precludes you from handling 
a custom json response as part of an ftl screen.

On the other hand if we agree that it makes sense to move it to ftl then I can 
go ahead and update to that implementation.

> Alter Json controller requests to move json behaviour to response (from event)
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2778
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2778
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bob Morley
>         Attachments: json.diff
>
>
> I think it would be better to apply the Json behaviour of a controller 
> request to the response and not by having multiple Json event types.  These 
> event types always seem to be a wrapped call to another event type that only 
> adds identical Json behaviour (ie. JsonServiceEventHandler wraps 
> ServiceEventHandler and simply adds a Json string to the response).
> Attached is a patch with this change implemented on the "Mark Viewed" 
> function in Order Manager.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to