Re: svn commit: r807938 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java

[Scott Gray]

What exception are you referring to? Abbreviation? Yes we have plenty of exceptions: SQL, XML, RSS, UOM, FTP, Info, PK, ECA, Seq, Crypto, Iter, Max, Ajax, Alt, init, etc.

Regards
Scott

On 27/08/2009, at 4:10 AM, Jacques Le Roux wrote:

We use verbose names in order to add clarity but in this case NS is more recognizable to people familiar with using Java for XML and for those who aren't their IDE will quickly explain the method to them based on the javadoc comment.

I was sure someone would answer this (I presumed the JDK name in createElementNS) but why should we make an exception here ? Most of the time, when you begin with exceptions you don't know where it will end. BTW, have we already such exceptions in OFBiz ?

Jacques

From: "Scott Gray" <scott.g...@hotwaxmedia.com>

That's what Ashish originally named it but I asked him to change it so that it better reflected the underlying jdk method name createElementNS. Anyone who knows what that method does will immediately know what this one does.

Regards
Scott

On 26/08/2009, at 11:34 PM, Jacques Le Roux wrote:

I'd have prefered addChildElementNameSpaceValue as name

Jacques

From: <lekt...@apache.org>

Author: lektran
Date: Wed Aug 26 09:22:09 2009
New Revision: 807938

URL: http://svn.apache.org/viewvc?rev=807938&view=rev
Log:


Modified:
 ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java


URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java?rev=807938&r1=807937&r2=807938&view=diff

@@ -586,6 +586,17 @@

      return newElement;
  }
+

+     */

+        element.appendChild(newElement);
+        return element;
+    }

Applied patch from Ashish Vijaywargiya that allows adding namespace aware child elements via UtilXml Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/util/ UtilXml.java = = = = = = = = = = = =================================================================== --- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/ UtilXml.java (original) +++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/ UtilXml.java Wed Aug 26 09:22:09 2009 newElement.appendChild(document.createTextNode(childElementValue)); + /** Creates a child element with the given namespace supportive name and appends it to the element child node list. + * Also creates a Text node with the given value and appends it to the new elements child node list. + public static Element addChildElementNSValue(Element element, String childElementName, + String childElementValue, Document document, String nameSpaceUrl) { + Element newElement = document.createElementNS(nameSpaceUrl, childElementName); + newElement.appendChild(document.createTextNode(childElementValue)); /** Creates a child element with the given name and appends it to the element child node list. * Also creates a CDATASection node with the given value and appends it to the new elements child node list.

smime.p7s
Description: S/MIME cryptographic signature