[ 
https://issues.apache.org/jira/browse/OFBIZ-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749237#action_12749237
 ] 

Ashish Vijaywargiya commented on OFBIZ-2874:
--------------------------------------------

Hello Erwan,

Thanks for your work on this.
Here are my comments on your work before it become part of trunk.

1) There is no need to create new tab by name "Validate leaves".
2) Remove both the forms and screen definition that you have created 
"ValidateEmplLeave" & "EditLeaveStatus".
3) Instead of this use Find Leave form and make it functional. 
3a) What you need to do here is only make the list form shown at the bottom on 
Find Leave form functional and add combo for Status.
After doing this changes you will be done from this work.
4) Also in the entity changes create the foreign key relationship with the 
StatusItem entity.

--
Ashish

> improvement on human res leave management
> -----------------------------------------
>
>                 Key: OFBIZ-2874
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2874
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: humanres
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2874.diff
>
>
> For the moment in ofbiz, we only have the possibility to create leaves.
> this patch will allow users to add a status on the leaves (required / 
> rejected / accepted / cancelled).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to