+1, I agree Adam has well shown the way
Jacques
From: "Tim Ruppert" <[email protected]>
+1 - thanks Adam - I agree whole heartedly on the incremental approach.
Cheers,
Ruppert
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com
o:801.649.6594
f:801.649.6595
On Sep 8, 2009, at 4:56 PM, Adam Heath wrote:
Adam Heath wrote:
I have external code(webslinger) that needs to support multiple
versions of ofbiz(one all the way back to 512946). This change makes
that impossible. I have to have multiple versions of ofbiz
installed(pre/post this change), and compile the class once for each
ofbiz version.
Well, based on this change, and what will eventually happen with
ExecutionContext, I've changed my build to support this. Kinda slick
actually.
I copied the old GenericDelegator.java, new GenericDelegator.java, and
DelegatorInterface.java, into my local build system. Modified the old
delegator, removing all comments, all method bodies, and made them all
throw UnsupportedOperationException. Compiled these classes locally.
Do some classpath tweaks during the build phase, and have 2 versions
of ofbiz-webslinger.jar. I then use debian versioned dependencies to
install the correct jar.
So, I don't need this backed out right now, altho I do think it is
still the correct thing to do. I also think an incremental approach
to ExecutionContext is also the preferred way.
