+1 from my side as well for this change. I will do the needful if nobody has objection on it in a day or so.
Thanks Pranay for initiating this email! -- Ashish On Fri, Sep 25, 2009 at 6:54 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > I can't see any problems, +1 > > Jacques > > From: "Vivek Mishra" <vivek.mis...@hotwaxmedia.com> > > > > +1. Yes I think this change won't harm anything and seems necessary indeed >> to accommodate long shipping method name. >> >> Thanks! >> -- >> Vivek Mishra >> >> >> Pranay Pandey wrote: >> >>> Hello Devs, >>> >>> I want propose a change in entity GoogleCoShippingMethod. >>> We should change field "shipmentMethodName" from type "id-ne" to >>> "id-long-ne". >>> The reason is the name of Shipping method can be longer and this will not >>> be accommodated in the present one. >>> >>> As these changes have done before few days so I think no one will be >>> using this on production and this change should not harm anything. >>> >>> Thoughts? >>> >>> >>> Thanks & Regards >>> -- >>> Pranay Pandey >>> HotWax Media | www.hotwaxmedia.com >>> >>> >> >
