[
https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Busco updated OFBIZ-3012:
-------------------------------
Attachment: screenlet.patch
uilabels.patch
Hi Adrian,
thank you for reviewing the patch.
I have separated now the patch related to Better Italian labels (uilabels.patch)
from the one related to the FindScreenDecorator (screenlet.patch)
You are right! There is no reason to change the screenlet tag to container. I
was convinced that this would have rendered a double screenlet-body section
(one from the screenlet widget rendering and one from the explicit container
that is in the file) but I have verified that it does not.
I have removed this change from the patch.
For "The content of the FindScreenDecorator is not properly contained in the
screenlet-body tag" I mean that in the FindScreenDecorator the code:
<container id="search-results">
<decorator-section-include name="search-results"/>
</container>
is not contained in the "screenlet-body" container and this is different from
what is rendered by the screenlet widget where ALL the content is inside the
screenlet-container.
The new bluelight theme does not render perfectly if content is not included in
the screenlet-body and this is the reason of the change.
Having ALL the content always included in the screenlet-body tag makes the HTML
rendered from the screenlet widget exactly equal to the one that is obtained by
an FTL or container widget.
-Bruno
> The content of the FindScreenDecorator is not properly contained in the
> screenlet-body tag
> ------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3012
> URL: https://issues.apache.org/jira/browse/OFBIZ-3012
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Priority: Minor
> Attachments: screenlet.patch, uilabels.patch
>
>
> The attached patch fixes this.
> BTW: include also:
> 1) few better Italian labels.
> 2) "screenlet" decorator removed (not used anymore)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
