Maybe you could leave out the "bad commit" part and just recommend the two separate commits :) - I like to see both features go in and bugs get fixed, so not so much bad as maybe another, even better way of handling it Scott!

Cheers,
Ruppert
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6595

On Oct 20, 2009, at 11:29 AM, Adam Heath wrote:

[email protected] wrote:
Author: lektran
Date: Sun Oct 18 00:34:29 2009
New Revision: 826322

URL: http://svn.apache.org/viewvc?rev=826322&view=rev
Log:
Catch ClassCastExceptions in <store-value/> operations, these will occur if you have a null GenericValue (perhaps from a lookup that returned no results), set some fields on it and then try to store it. What you actually have at that point is a FastMap created when you set the fields. Also added use of the utility MethodContext.setErrorReturn(String, SimpleMethod) rather than manually adding errors to the environment context.

Bad commit, this is 2 separate changes, should have been done as 2
separate commits.  One is a bug fix, the other is just a feature.


Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to