[
https://issues.apache.org/jira/browse/OFBIZ-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781091#action_12781091
]
Adrian Crum commented on OFBIZ-3245:
------------------------------------
David,
Thank you so much for the review and comments! I will include them in whatever
version makes its way into the trunk.
You said:
"Previously the Entity Engine expected you to pass a valid data type, would
warn you if it wasn't what was expected (according to the fieldtypes*.xml file
that was active), and then pass it on as-is to the JDBC driver to handle, or to
blow up on."
The change I'm trying to introduce is this: You can give the Entity Engine any
Java data type, and it will attempt to get/store it. There is no need to
"guess" what the driver expects. If the attempt fails, it is because the
conversion is not logical, it is not because there is some preconceived idea of
what is acceptable.
As far as performance on switch statements is concerned, I have written C++
code that is similar and I'm pretty sure that complicated conditionals are not
"free." I have not evaluated Java switch statements, so I might be wrong.
By the way, what database did you evaluate this with? I need as much input as I
can get.
> Sandbox: Integrating The New Conversion Framework Into The Entity Engine
> ------------------------------------------------------------------------
>
> Key: OFBIZ-3245
> URL: https://issues.apache.org/jira/browse/OFBIZ-3245
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: conversion.patch, conversion.patch
>
>
> This issue contains a patch intended for evaluation before it is committed.
> See comments for details.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
