[ 
https://issues.apache.org/jira/browse/OFBIZ-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783102#action_12783102
 ] 

Jacques Le Roux commented on OFBIZ-2000:
----------------------------------------

Hi Rishi,

Yes, having only one piece of code should be better. For js code, if it's 
specific to this page I can't see any harm to put it there.

In this file I discovered this comment which is great and it would be even 
better if we could put thisi in the contributor best practices. Maybe also we 
should refactor the contributor best practices page because it tends to become 
a bit long. We could split it in sub-pages for instance...

<#------------------------------------------------------------------------------
NOTE: all page headings should start with an h2 tag, not an H1 tag, as 
there should generally always only be one h1 tag on the page and that 
will generally always be reserved for the logo at the top of the page.
------------------------------------------------------------------------------->

Thanks for your help guys (and ladyes maybe) !




> Added check availability functionality on new create profile page of e 
> commerce.
> --------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2000
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2000
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/ecommerce
>            Reporter: Rishi Solanki
>            Priority: Minor
>         Attachments: CheckAvailUsername.patch, CheckAvailUsername.patch, 
> CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, 
> CheckAvailUserName.patch, CheckAvailUserName.patch, 
> FOR_TEST_OFBIZ-2000.patch, OFBIZ-2000.patch
>
>
> After adding this functionality while creating a profile from e commerce new 
> profile pages, user will be able to check his/her selected userLoginId is 
> availabel or not. Instead after submitting the whole form can check it just 
> by clicking on a check availability link. For this implementation can use 
> Ajax.request for submitting the user name and finally getting back the error 
> list from the server. If got the error appear it else hide.
> Affected files for this feature are ;
> CustomerEvents.xml ----> ecommerce
> profile.js ---> ecommerce
> NewCustomer.ftl ---> ecommerce (for new one)
> Regards
> - Rishi Solanki

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to