[
https://issues.apache.org/jira/browse/OFBIZ-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793857#action_12793857
]
Scott Gray commented on OFBIZ-3211:
-----------------------------------
Here's a few comments, nothing that blocks committing your patch, just things
we need to think about improving at some point:
- you can't search for a string that spans across multiple fields e.g. entering
firstName and a partial lastName will return no results. I guess we can't do
anything about this until the entity engine supports string concatenation (it
doesn't right?).
- when the session has expired the autocompleter stops working properly but no
feedback is given to the user
- I'm not sure if we're worried about this right now but I've noticed that
autocompleters used by other apps often hide the key from the user and only
display the description in the textbox (much like a dropdown). Only raising
this here as something we need to think about supporting.
- we should avoid returning html from the server since it is specific to the
script.aculo.us autocompleter and instead return a json object which can then
be converted in whatever format is necessary.
- we should use EntityFindOptions.setMaxRows rather than trimming the results
after the search
> Ajaxifying lookup fields
> ------------------------
>
> Key: OFBIZ-3211
> URL: https://issues.apache.org/jira/browse/OFBIZ-3211
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ajax-loader.gif, ajaxLookup.patch, ajaxLookup.patch
>
>
> To see how it works, apply the patch (optionally add ajax-loader.gif to
> framework\images\webapp\images\) and go to Accounting -> Find Invoices (or to
> any other screen with form widget that uses LookupPartyName lookup ). Then
> type some letters to From Party ID or To Party ID fields.
> Bilgin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
