[
https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795033#action_12795033
]
Bruno Busco commented on OFBIZ-3374:
------------------------------------
Hi Sascha,
I have looked at your latest patch.
Few comments:
1) Are we sure we can commit the resize.js file as it is? There is a license
note that I do not know if is compatible with the Apache. I would like others
to check at least thi file in the patch.
2) To check that a section is empty there is now the tag <if-empty-section
section-name="body"/> you should use instead of <if-empty
field="sections.body"/>
3) There are some conflict with the latest trunk
4) Generally to get the review simpler is better to remove all the formatting
changes (there are lots of trailing spaces removal)
5) Where and which gif file need to be added to let the patch work?
Thank you Sascha for the continued effort with this but I try to do my best to
avoid wrong things committed. I hope you understand.
> UI upgrade, new lookups
> -----------------------
>
> Key: OFBIZ-3374
> URL: https://issues.apache.org/jira/browse/OFBIZ-3374
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: header_bg.gif, header_close_button.png, lookup.jpg,
> lookup2.jpg, lookups.patch, lookups.patch, lookups.patch, lookups.patch,
> lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel:
> [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29]
> I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about
> the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
