Tim Ruppert wrote: > Not trying to - but sorry for the tone if it came across that way Hans. I'm > simply asking why it gets past the committer's desk as "I'm trying to get my > people to provide smaller pieces" is an ok way of committing code. Isn't > that the responsibility of the committer to tell the person that's providing > the code to go back to the drawing board and break it up? Isn't that our job > as committers? And as the rest of the committers, isn't it our job to remind > the offending committer to spend more time with the person who's providing > the code so that we don't have to dig thru this much mess? > > It's not always easy for any of us, but I just don't see this from other > people, so I wanted to remind Hans. If all the other committers think this > is ok (which obviously they didn't since Adam brought it up), then I'll > happily back off. Since that's not the case - and this obviously doesn't > follow the best practices of the project - please let me know how I should > encourage Hans to do what is clearly in our best practices. > > What should be done is that this mess of a commit should be reverted and put > back in in pieces - you have to start somewhere and sometimes it's just not > good enough when you have an entire community to just say you're trying hard. > My two cents.
Reverting the commit is wrong. Just try to be more careful in the future.
