On Jan 31, 2010, at 9:41 AM, Hans Bakker wrote:

> It Was a customer requirement to see in the sales chanel of it was b2b
> or b2c
> 

I could write a book with all the weird requests I have received from customers.
The difficult role of an analysis/consultant is to try to convince the customer 
to implement the requirements in the most "correct" way (because in the long 
term this is a win for the customer and for sure it is for the project), but I 
know that sometimes this is impossible and the customer forces you to follow 
the shortest (and cheapest in the *short* term) path. However when this happens 
we, as committers, have to keep this code out of the official trunk (even if 
the work itself could have a value for other customers, and I am sure it has). 
That is why I suggested to add this data to Jira.

Kind regards,

Jacopo


> On Sun, 2010-01-31 at 00:03 -0800, Scott Gray wrote:
>> Hi Hans,
>> 
>> A Sales Channel has nothing to do with what store the sale came in through, 
>> it's about what sales channel it arrived from.  The OrderHeader contains the 
>> productStoreId so what additional information are your able to derive by 
>> having a separate enumeration which also signifies the product store?
>> 
>> If you have a separate product store for B2B vs. B2C then I don't see what 
>> you are gaining by having additional sales channels, please explain.
>> 
>> Thanks
>> Scott
>> 
>> On 30/01/2010, at 8:25 PM, Hans Bakker wrote:
>> 
>>> I am sorry Scott i do not agree with you.
>>> 
>>> Our customers like to know if he sale is to end consumer or business.
>>> 
>>> Regards,
>>> Hans
>>> 
>>> 
>>> On Fri, 2010-01-29 at 11:17 -0700, Scott Gray wrote:
>>>> Hi Hans,
>>>> 
>>>> The Sales Channel Enumerations below are incorrect, they shouldn't be tied 
>>>> to specific ProductStores such as "B2C eBay Australia Channel" it should 
>>>> simply be "eBay Australia Channel" since the ProductStore information is 
>>>> already retrievable from the order.  I think these serve as a bad example 
>>>> for demo data, please consider removing them.
>>>> 
>>>> Regards
>>>> Scott
>>>> 
>>>> HotWax Media
>>>> http://www.hotwaxmedia.com
>>>> 
>>>> On 25/01/2010, at 12:23 AM, hans...@apache.org wrote:
>>>> 
>>>>> Modified: ofbiz/trunk/applications/order/data/SalesOrderDemoData.xml
>>>>> URL: 
>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/data/SalesOrderDemoData.xml?rev=902719&r1=902718&r2=902719&view=diff
>>>>> ==============================================================================
>>>>> --- ofbiz/trunk/applications/order/data/SalesOrderDemoData.xml (original)
>>>>> +++ ofbiz/trunk/applications/order/data/SalesOrderDemoData.xml Mon Jan 25 
>>>>> 07:23:57 2010
>>>>> @@ -19,18 +19,30 @@
>>>>> -->
>>>>> 
>>>>> <entity-engine-xml>
>>>>> +    <!-- to make the data load the first time -->
>>>>> +    <Facility facilityId="WebStoreWarehouse"/>
>>>>> +    
>>>>> +    <!-- PRODUCT STORE -->
>>>>> +    <ProductStore productStoreId="B2CStore" storeName="B2C Store" 
>>>>> companyName="Open For Business" autoApproveReviews="Y" title="Open For 
>>>>> Business to Customer"
>>>>> +        subtitle="" prorateShipping="Y" prorateTaxes="Y" 
>>>>> defaultLocaleString="en_US" defaultCurrencyUomId="USD"
>>>>> +        autoApproveInvoice="Y" autoApproveOrder="Y" 
>>>>> shipIfCaptureFails="Y" requireInventory="N" reserveInventory="Y" 
>>>>> inventoryFacilityId="WebStoreWarehouse"
>>>>> +        orderNumberPrefix="B2CS" visualThemeId="EC_DEFAULT" 
>>>>> payToPartyId="Company" defaultSalesChannelEnumId="WEB_SALES_CHANNEL"/>
>>>>> +    <ProductStore productStoreId="B2BStore" storeName="B2B Store" 
>>>>> companyName="Open For Business" autoApproveReviews="Y" title="Open For 
>>>>> Business to Business"
>>>>> +        subtitle="" prorateShipping="Y" prorateTaxes="Y" 
>>>>> defaultLocaleString="en_US" defaultCurrencyUomId="USD"
>>>>> +        autoApproveInvoice="Y" autoApproveOrder="Y" 
>>>>> shipIfCaptureFails="Y" requireInventory="N" reserveInventory="Y" 
>>>>> inventoryFacilityId="WebStoreWarehouse"
>>>>> +        orderNumberPrefix="B2BS" visualThemeId="EC_DEFAULT" 
>>>>> payToPartyId="Company" defaultSalesChannelEnumId="WEB_SALES_CHANNEL"/>
>>>>> 
>>>>>   <!-- ORDER SALES CHANNEL -->
>>>>> -    <Enumeration enumId="VV_AU_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_VV_AU_CHANNEL"  
>>>>> sequenceId="9" description="VV eBay Australia Channel"/>
>>>>> -    <Enumeration enumId="VV_CA_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_VV_CA_CHANNEL"  
>>>>> sequenceId="10" description="VV eBay Canada Channel"/>
>>>>> -    <Enumeration enumId="VV_IE_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_VV_IE_CHANNEL"  
>>>>> sequenceId="11" description="VV eBay Ireland Channel"/>
>>>>> -    <Enumeration enumId="VV_SG_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_VV_SG_CHANNEL"  
>>>>> sequenceId="12" description="VV eBay Singapore Channel"/>
>>>>> -    <Enumeration enumId="VV_UK_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_VV_UK_CHANNEL"  
>>>>> sequenceId="13" description="VV eBay United Kingdom Channel"/>
>>>>> -    <Enumeration enumId="VV_US_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_VV_US_CHANNEL"  
>>>>> sequenceId="14" description="VV eBay United States Channel"/>
>>>>> -    <Enumeration enumId="VV_DE_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_VV_DE_CHANNEL"  
>>>>> sequenceId="15" description="VV eBay Germany Channel"/>
>>>>> -    <Enumeration enumId="VV_ES_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_VV_ES_CHANNEL"  
>>>>> sequenceId="16" description="VV eBay Spain Channel"/>
>>>>> -    <Enumeration enumId="VV_FR_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_VV_FR_CHANNEL"  
>>>>> sequenceId="17" description="VV eBay France Channel"/>
>>>>> -    <Enumeration enumId="VV_IT_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_VV_IT_CHANNEL"  
>>>>> sequenceId="18" description="VV eBay Italy Channel"/>
>>>>> +    <Enumeration enumId="B2C_AU_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_B2C_AU_CHANNEL"  
>>>>> sequenceId="9" description="B2C eBay Australia Channel"/>
>>>>> +    <Enumeration enumId="B2C_CA_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_B2C_CA_CHANNEL"  
>>>>> sequenceId="10" description="B2C eBay Canada Channel"/>
>>>>> +    <Enumeration enumId="B2C_IE_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_B2C_IE_CHANNEL"  
>>>>> sequenceId="11" description="B2C eBay Ireland Channel"/>
>>>>> +    <Enumeration enumId="B2C_SG_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_B2C_SG_CHANNEL"  
>>>>> sequenceId="12" description="B2C eBay Singapore Channel"/>
>>>>> +    <Enumeration enumId="B2C_UK_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_B2C_UK_CHANNEL"  
>>>>> sequenceId="13" description="B2C eBay United Kingdom Channel"/>
>>>>> +    <Enumeration enumId="B2C_US_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_B2C_US_CHANNEL"  
>>>>> sequenceId="14" description="B2C eBay United States Channel"/>
>>>>> +    <Enumeration enumId="B2C_DE_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_B2C_DE_CHANNEL"  
>>>>> sequenceId="15" description="B2C eBay Germany Channel"/>
>>>>> +    <Enumeration enumId="B2C_ES_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_B2C_ES_CHANNEL"  
>>>>> sequenceId="16" description="B2C eBay Spain Channel"/>
>>>>> +    <Enumeration enumId="B2C_FR_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_B2C_FR_CHANNEL"  
>>>>> sequenceId="17" description="B2C eBay France Channel"/>
>>>>> +    <Enumeration enumId="B2C_IT_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_B2C_IT_CHANNEL"  
>>>>> sequenceId="18" description="B2C eBay Italy Channel"/>
>>>>>   <Enumeration enumId="B2B_AU_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_B2B_AU_CHANNEL"  
>>>>> sequenceId="19" description="B2B eBay Australia Channel"/>
>>>>>   <Enumeration enumId="B2B_CA_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_B2B_CA_CHANNEL"  
>>>>> sequenceId="20" description="B2B eBay Canada Channel"/>
>>>>>   <Enumeration enumId="B2B_IE_SALES_CHANNEL" 
>>>>> enumTypeId="ORDER_SALES_CHANNEL" enumCode="EBAY_B2B_IE_CHANNEL"  
>>>>> sequenceId="21" description="B2B eBay Ireland Channel"/>
>>>> 
>>> -- 
>>> Antwebsystems.com: Quality OFBiz services for competitive rates
>>> 
>> 
> -- 
> Antwebsystems.com: Quality OFBiz services for competitive rates
> 

Reply via email to