Okay, I found the problem and committed a fix. We really need to go
through the framework and fix the code that uses FlexibleStringExpander
in inappropriate ways.
FlexibleStringExpander.getInstance will ALWAYS return an instance, so
there is no need to check if an instance is equal to null.
Checking FlexibleStringExpander.getOriginal() for null or empty is bad
coding style. There is an isEmpty() method for that.
-Adrian
Adrian Crum wrote:
Hans,
How is that commit affecting UI labels?
-Adrian
Hans Bakker wrote:
Hi this seems to be caused by r904592
to revert this change:
svn merge http://svn.apache.org/repos/asf/ofbiz/trunk -r904592:904591
Regards,
Hans
On Mon, 2010-02-01 at 23:07 -0800, Scott Gray wrote:
After taking an update today, a lot of form widget field labels seem
to be missing from various screens. If any committers are aware of
any changes they may have made which could have impacted this please
take a look and see if it's related to your work.
Here's an example:
https://localhost:8443/catalog/control/FindProductConfigItems (only
one of the 3 search option fields are presenting a field label)
Here's another: https://localhost:8443/accounting/control/findPayments
Thanks
Scott
HotWax Media
http://www.hotwaxmedia.com
